Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the defaults in a JSON file #1039

Closed
2 of 3 tasks
Tracked by #974
clizbe opened this issue Feb 21, 2025 · 3 comments
Closed
2 of 3 tasks
Tracked by #974

Put the defaults in a JSON file #1039

clizbe opened this issue Feb 21, 2025 · 3 comments

Comments

@clizbe
Copy link
Member

clizbe commented Feb 21, 2025

Start with the defaults file Diego has drafted here in function get_default_values:
https://github.com/TulipaEnergy/Tulipa-OBZ-CaseStudy/blob/main/utils/functions.jl

Also consider:

@clizbe clizbe self-assigned this Feb 21, 2025
@datejada
Copy link
Member

One option is to have a JSON file that has the schema, description of the parameters, recommended units, and defaults. Issue #992 will also help with #1038 since it can be reused to print it in the docs.

@clizbe
Copy link
Member Author

clizbe commented Feb 24, 2025

Yes I looked up how one of the solvers stored their defaults, and it was something like this. Although I think theirs were just in a markdown file.

@clizbe clizbe changed the title Put the defaults in a TOML file Put the defaults in a JSON file Feb 28, 2025
@clizbe clizbe removed their assignment Mar 3, 2025
@clizbe
Copy link
Member Author

clizbe commented Mar 6, 2025

Closed by #1054.
Still need to make features explicit so it doesn't just infer if data is present/missing, but that continues with #996

@clizbe clizbe closed this as completed Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants