Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clustering #9

Merged
merged 16 commits into from
Dec 5, 2023
Merged

Implement clustering #9

merged 16 commits into from
Dec 5, 2023

Conversation

greg-neustroev
Copy link
Collaborator

Pull request details

Describe the changes made in this pull request

Implemented k-means and k-medoids clustering of data.

List of related issues or pull requests

Closes #3

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (494ecf5) 100.00% compared to head (66a0b1f) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main        #9    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         4     +1     
  Lines           12       129   +117     
==========================================
+ Hits            12       129   +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have another issue with the output to CSV. We need to coordinate that part with the files we expect in TulipaEnergyModel.jl. It is to keep it in sight. So, I approve this PR. Thanks!

@datejada datejada merged commit d37d3c1 into main Dec 5, 2023
13 checks passed
@datejada datejada deleted the 3-implement-clustering branch December 5, 2023 07:46
@greg-neustroev
Copy link
Collaborator Author

I see you have another issue with the output to CSV. We need to coordinate that part with the files we expect in TulipaEnergyModel.jl. It is to keep it in sight. So, I approve this PR. Thanks!

@datejada I will implement the output saving in the old format first, and then will make a separate issue for aligning the inputs and outputs with the current Tulipa formulation. I think this would be easier to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement clustering
2 participants