Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

angular 10 compatibility issue #13

Open
damianroszyk opened this issue Jul 31, 2020 · 4 comments · Fixed by #14
Open

angular 10 compatibility issue #13

damianroszyk opened this issue Jul 31, 2020 · 4 comments · Fixed by #14

Comments

@damianroszyk
Copy link

Hello,

I am getting error trying to ng update my project with following error:
Package "@trilon/ng-universal" has an incompatible peer dependency to "@angular/core" (requires "^7.0.0" (extended), would install "10.0.7").

Any plans on updating this library ?
@MarkPieszak
Copy link
Member

MarkPieszak commented Aug 13, 2020 •
edited
Loading

Yes let me get these fixed asap! :)
@damianroszyk

@MarkPieszak
Copy link
Member

Just published v 3.0.1, it should be all fixed up now! 🚀

@damianroszyk
Copy link
Author

Great, thanks for update 😊

@MarkPieszak MarkPieszak mentioned this issue Aug 13, 2020
Merged
@damianroszyk
Copy link
Author

Hello again,
looks like there is a problem with this new version
ERROR in Unexpected value 'NgUniversalModule in @trilon/ng-universal/lib/ng-universal.module.d.ts' Please add a @NgModule annotation.

My app doesn't use Ivy and I think it's related?

@damianroszyk damianroszyk reopened this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(publish): 3.0.1 - angular 10 updates TrilonIO/ng-universal
2 participants
@MarkPieszak @damianroszyk