From e93d98ac13e5d6f45ef20c8f32c26683fbbbcb05 Mon Sep 17 00:00:00 2001
From: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Date: Fri, 24 Jan 2025 15:37:30 +0000
Subject: [PATCH] :bug: Fix PLC0206 (#907)

* :bug: Fix PLC0206
- Fix PLC0206 Extracting value from dictionary without calling `.items()`
---
 tiatoolbox/models/engine/engine_abc.py |  8 +++-----
 tiatoolbox/utils/misc.py               | 11 +++++------
 2 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/tiatoolbox/models/engine/engine_abc.py b/tiatoolbox/models/engine/engine_abc.py
index 6e33da409..8f0adc310 100644
--- a/tiatoolbox/models/engine/engine_abc.py
+++ b/tiatoolbox/models/engine/engine_abc.py
@@ -505,13 +505,11 @@ def get_dataloader(
     @staticmethod
     def _update_model_output(raw_predictions: dict, raw_output: dict) -> dict:
         """Helper function to append raw output during inference."""
-        for key in raw_output:
+        for key, value in raw_output.items():
             if raw_predictions[key] is None:
-                raw_predictions[key] = raw_output[key]
+                raw_predictions[key] = value
             else:
-                raw_predictions[key] = np.append(
-                    raw_predictions[key], raw_output[key], axis=0
-                )
+                raw_predictions[key] = np.append(raw_predictions[key], value, axis=0)
 
         return raw_predictions
 
diff --git a/tiatoolbox/utils/misc.py b/tiatoolbox/utils/misc.py
index 473fa94c0..b786517a7 100644
--- a/tiatoolbox/utils/misc.py
+++ b/tiatoolbox/utils/misc.py
@@ -1490,20 +1490,19 @@ def write_to_zarr_in_cache_mode(
 
     # case 1 - new zarr group
     if not zarr_group:
-        for key in output_data_to_save:
-            data_to_save = output_data_to_save[key]
+        for key, value in output_data_to_save.items():
             # populate the zarr group for the first time
             zarr_dataset = zarr_group.create_dataset(
                 name=key,
-                shape=data_to_save.shape,
+                shape=value.shape,
                 compressor=compressor,
             )
-            zarr_dataset[:] = data_to_save
+            zarr_dataset[:] = value
 
         return zarr_group
 
     # case 2 - append to existing zarr group
-    for key in output_data_to_save:
-        zarr_group[key].append(output_data_to_save[key])
+    for key, value in output_data_to_save.items():
+        zarr_group[key].append(value)
 
     return zarr_group