Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address build failure with older ocaml versions (< 4.13) #23

Closed
wants to merge 1 commit into from

Conversation

snapdgn
Copy link

@snapdgn snapdgn commented Jun 1, 2024

Fixes: #22

@snapdgn
Copy link
Author

snapdgn commented Jun 1, 2024

@ThinkOpenly We can probably separate those utility function to a separate utils.ml.
Let me know if you have any suggestions to improve this.

@snapdgn snapdgn marked this pull request as draft June 1, 2024 08:44
@ThinkOpenly
Copy link
Owner

@ThinkOpenly We can probably separate those utility function to a separate utils.ml.

I agree with your proposal to move the utility functions into a utils.ml file in src/sail_json_backend. The rest looks fine.

It'll be nice to make the workflows, well, work for us. Thanks!

@ThinkOpenly ThinkOpenly mentioned this pull request Jun 3, 2024
@snapdgn
Copy link
Author

snapdgn commented Jun 4, 2024

Closing this PR, as all workflow-related fixes are now consolidated in #24 .

@snapdgn snapdgn closed this Jun 4, 2024
@snapdgn snapdgn deleted the fix-backward-compatibility branch June 11, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure with older ocaml versions (< 4.13)
2 participants