You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I was working on fixing the build workflow, I noticed that upstream sail uses, two version 4.08.1 & 5.0.0 of ocaml to test the build.
We currently use String.starts_with & String.ends_with in our json backend(json.ml), which were introduced in ocaml version 4.13.0. Consequently, attempting to build our backend with versions prior to 4.13.0 results in failure.
The same applies to find_map. There may be other instances as well.
Given that upstream continues to use version 4.08.1 for testing builds, it seems sensible to maintain backward compatibility.
The only question is how far back we should provide support?
The text was updated successfully, but these errors were encountered:
While I was working on fixing the build workflow, I noticed that upstream sail uses, two version
4.08.1
&5.0.0
of ocaml to test the build.We currently use
String.starts_with
&String.ends_with
in our json backend(json.ml
), which were introduced in ocaml version4.13.0
. Consequently, attempting to build our backend with versions prior to4.13.0
results in failure.The same applies to
find_map
. There may be other instances as well.Given that upstream continues to use version
4.08.1
for testing builds, it seems sensible to maintain backward compatibility.The only question is how far back we should provide support?
The text was updated successfully, but these errors were encountered: