Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with older ocaml versions (< 4.13) #22

Open
snapdgn opened this issue Jun 1, 2024 · 0 comments
Open

Build failure with older ocaml versions (< 4.13) #22

snapdgn opened this issue Jun 1, 2024 · 0 comments

Comments

@snapdgn
Copy link

snapdgn commented Jun 1, 2024

While I was working on fixing the build workflow, I noticed that upstream sail uses, two version 4.08.1 & 5.0.0 of ocaml to test the build.

We currently use String.starts_with & String.ends_with in our json backend(json.ml), which were introduced in ocaml version 4.13.0. Consequently, attempting to build our backend with versions prior to 4.13.0 results in failure.
The same applies to find_map. There may be other instances as well.

Given that upstream continues to use version 4.08.1 for testing builds, it seems sensible to maintain backward compatibility.
The only question is how far back we should provide support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant