-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repentogon doesn't work after succesful install #588
Comments
And? |
Please define not working; please check for presence of (and post if it exists) dsound.log, libzhl.log, and repentogon.log; these will all be in the root folder where repentogon should be installed |
edited first post, accidentally pressed enter with blank sheet. Dsound log [Options] [internal] other 2 files are not present in my game dir |
that's dsound.ini. can you verify how and where you installed repentogon? |
downloaded latest Repentogonupdater, dropped it in The Binding of Isaac Rebirth folder (located it through steam), ran it, it downloaded the rest of files, said that the installation was succesful but when i launch the game either from steam or through isaacng.exe i don't see anywhere that repentogon works and when i launch a fresh run i see big red text saying it's noy installed properly |
you are potentially suffering from an issue where our dsound.dll hook does not work. while it's not in a release-ready state, a new launcher solution that we intend to switch to recently entered alpha state. you might try it and see if that works better |
Sorry, latest version https://github.com/TeamREPENTOGON/Launcher/releases/tag/v0.1.1-alpha |
windows defender screams it's bad, i assume nothing to worry about? |
|
when using launcher 2 errors, missing ucrtbased.dll and vcruntime140d.dll, Am i missing some frameworks or other essentials? |
The launcher is actually not ready for the public yet, those dlls are debugging dlls that we need internally to properly traceback issues with it, they wont be needed when we poop it out....if you are truly having the issue where the game doesnt load dsound.dll at all then you'll need to wait until we release the launcher proper to use repentogon. |
It's true that it isn't ready for public, but I personally think it's worth having extra eyes on it as necessary. The missing dlls are debug variants, I found an older gl issue on github where someone dumped specifically those ones WHTJEON/narrowvine#2 |
I don't think the alpha version of the launcher solves the problem for me. I'm one of those unlucky players whose PC doesn't load dsound.dll and simply starts the game without RGON (no errors or anything). The issue is that the same happens with the launcher, even though I have selected the correct isaac-ng.exe and changed the launch mode to "Repentogon". The launcher does give me these warnings: I tried deleting dsound.dll in hopes that it would make the launcher use the loader, but when I did, it couldn't find Repentogon at all. Is there anything else I can do? |
In the launcher, click "Advanced Options" and upgrade to unstable Repentogon, instead of stable. Right now what is happening is that the launcher downloads a dsound.dll based Repentogon because it downloads stable releases by default. This means your libzhl.dll and zhlRepentogon.dll are not properly setup to work with the launcher. Upgrading to an unstable Repentogon release should fix the issue. If you can try this and come back to us, that would be very appreciated as it would be the first instance of someone with a non working dsound based installation using the launcher. If it still doesn't work, please send us your launcher.log file |
Upgrading to the latest unstable version removed the warnings, but, as far as I can tell, the game still launches without RGON. At least, I don't see anything RGON-related on the title screen, and the console window is completely unchanged. Here's my launcher.log. |
Did a libzhl.log and/or zhl.log and/or Repentogon.log generate, if so, can we take a look at those? |
It doesn't generate libzhl.log, but here are the other two: |
There should be an additional file called zhlLoader.log, can you send us that one as well ? |
There you go: |
I added some logs in Repentogon in order to better understand what is happening. Can you do the following:
Thank you |
It does say "4" here:
But then:
So I'm not exactly sure which version it's trying to use. Anyway, here are the .log files: |
Little oversight on my end, forgot to update the version internally, I've checked the logs it's all good, you're on the latest pre release |
I'm having a very precise idea of where the issue is, though I'm still not sure of what is triggering it. I've pushed a new unstable version of Repentogon, can you repeat the same steps as before and upload the files once they are ready ? Thank you (also the version string should be good this time :) ) |
Can you repeat the procedure one more time ? I may have identified why it doesn't work for you and I have uploaded a new unstable release, but it's still only suppositions |
I've uploaded a new unstable release. It doesn't change anything logic-wise, but it adds even more logs so we may figure out what is happening. Can you repeat the procedure again ? I'm sorry about how this debug works :x Unfortunately none of us are able to reproduce the issue locally, and without direct access to your setup there is no way for us to come up with a definitive solution, we can only make guesses and progressively check which ones are correct and which ones are incorrect. To give you an idea of what is happening, Repentogon is closer to starting than it has ever been. Previously, your setup did not even load ZHL (the DLL that setups everything in memory) nor did it load Repentogon. Now, your setup loads ZHL (which is probably the most important step, without ZHL Repentogon would do nothing), but it fails to load Repentogon. My theory right now is that the game does not start in a suspended state, and the latest unstable release should tell us about that. Thank you for bearing with us |
Yeah, no problem. |
Here's a different version of libzhl.dll (in a zip file because Github won't allow direct upload of a DLL file). Please extract it next to the game and start Repentogon from the launcher. The game should crash pretty much instantly. The previous test showed that the game is properly suspended, as we expect. With this test I want to check if the changes made in memory to the game are seen by the game or not. If the game crashes then the changes are seen, and there may be an issue with what we do when we change memory. If the game does not crash then the changes are not seen, and we can start investigating why. Thank you in advance |
Could this possibly be an issue from using a Debug compiled launcher without the full debug redistributables installed? I initially linked just the two dlls the launcher asked for in order to launch. |
No. If that was the problem then either:
However, even if I think that's not possible, we should check that hypothesis. If my latest suggestion is not conclusive I'll release an unstable Release build of Repentogon just to check |
I already tested the exact situation phrogge described with just copying the debug dlls to the isaac folder on a system without them and it worked just fine, so I dont think thats a lead of any kind, no. Copying the provided dlls should be enough. |
I replaced libzhl.dll with the new one, but the game launched as usual, no crashes. |
I finally realized what the issue is : your game is simply not starting with Repentogon injected in it. We can see it by checking the logs: From last night: From the very last test your did: We can see the game dies less than one second after being launched, yet you say the game ran fine. I have a theory as to why : Steam is detecting changes in the memory and it shuts down the game before restarting it, without Repentogon obviously because there is no longer anything injected in memory. This is something I've already seen happen (in fact when I started suspecting this is what's happening, I remembered it happening to me two years ago). Here's what I would like you to try: do not change any DLLs, simply drop this file right next to your Isaac executable: Then, as usual, delete all log files, and start Repentogon from the launcher. Thank you very much :) |
This time the game crashed immediately (no errors, just closed itself a second after launching). |
Excellent ! Perfect, this is exactly what should have happened ! This means my theory was correct, it was Steam all along (the steam_appid.txt file prevents Steam from doing some sanity checks regarding memory, Antibirth used it as well) ! What you can do now is start the launcher > Advanced Options > force update Repentogon to latest unstable release, it will give you a clean libzhl.dll. Be sure to keep the steam_appid.txt file next to your Isaac executable ! Once the update is done, try launching Repentogon from the launcher. This time it should work. |
Yep, it's finally working. |
Thank you so much for bearing with us, I'll update the launcher so that it adds the steam_appid.txt file before starting the game. Your testing was invaluable 🥇 |
downloaded updater from github, succesful installation, doesn't work. No in-game bottom right corner text that it works, A mod that uses repentogon doesn't work and i have giant red text saying it's not installed properly when i launch the game. Tried manually coyping files and installing same thing.
The text was updated successfully, but these errors were encountered: