From 50565d21b787073326f7c3723f6db994dcc77fd9 Mon Sep 17 00:00:00 2001 From: Sookyung Kang Date: Fri, 12 Apr 2024 22:39:57 +0900 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F:=20fix=20=EC=BD=94=EB=93=9C?= =?UTF-8?q?=EB=A6=AC=EB=B7=B0=20=EB=B0=98=EC=98=81=20=EC=88=98=EC=A0=95(?= =?UTF-8?q?=EB=B9=A0=EC=A7=84=20=EC=BD=94=EB=93=9C,=20null)=20=20#38?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/th/plu/api/service/answer/AnswerService.kt | 12 ++---------- .../domain/question/explorer/QuestionExplorer.kt | 5 +++-- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/plu-api/src/main/kotlin/com/th/plu/api/service/answer/AnswerService.kt b/plu-api/src/main/kotlin/com/th/plu/api/service/answer/AnswerService.kt index 8342712..8bcb03c 100644 --- a/plu-api/src/main/kotlin/com/th/plu/api/service/answer/AnswerService.kt +++ b/plu-api/src/main/kotlin/com/th/plu/api/service/answer/AnswerService.kt @@ -77,6 +77,7 @@ class AnswerService( return EveryAnswerInfoResponse.of(todayQuestion, answerCount) } + @Transactional(readOnly = true) fun findAllAnswersLikeTopN(getCount: Long): EveryAnswerRetrieveResponses { val todayQuestion = questionExplorer.findTodayQuestion() val answers = answerRepository.findPublicAnswersLikeTopN(todayQuestion.id, getCount) @@ -92,16 +93,7 @@ class AnswerService( return try { answerRegister.registerAnswer(memberEntity, questionEntity, answerWriting.body, answerWriting.open).let { - WritingAnswerResult( - questionId = questionEntity.id, - questionTitle = questionEntity.title, - questionContent = questionEntity.content, - questionExposedAt = questionEntity.exposedAt, - questionElementType = questionEntity.elementType, - questionAnswered = true, - answerId = it.id, - answerBody = it.content, - reactionLikeCount = 0 // 최초 생성시는 0 + WritingAnswerResult(questionId = questionEntity.id, questionTitle = questionEntity.title, questionContent = questionEntity.content, questionExposedAt = questionEntity.exposedAt, questionElementType = questionEntity.elementType, questionAnswered = true, answerId = it.id, answerBody = it.content, reactionLikeCount = 0 // 최초 생성시는 0 ) } } catch (e: DataIntegrityViolationException) { diff --git a/plu-domain/src/main/kotlin/com/th/plu/domain/domain/question/explorer/QuestionExplorer.kt b/plu-domain/src/main/kotlin/com/th/plu/domain/domain/question/explorer/QuestionExplorer.kt index 94c18af..f0e59dc 100644 --- a/plu-domain/src/main/kotlin/com/th/plu/domain/domain/question/explorer/QuestionExplorer.kt +++ b/plu-domain/src/main/kotlin/com/th/plu/domain/domain/question/explorer/QuestionExplorer.kt @@ -14,8 +14,9 @@ class QuestionExplorer( private val questionRepository: QuestionRepository, ) { fun findQuestion(id: Long): Question = - questionRepository.findById(id).orElse(null) - ?: throw NotFoundException(ErrorCode.NOT_FOUND_QUESTION_EXCEPTION, "존재하지 않는 질문 $id 입니다") + questionRepository.findById(id).orElseThrow { + NotFoundException(ErrorCode.NOT_FOUND_QUESTION_EXCEPTION, "존재 하지 않는 질문 $id 입니다") + } fun findQuestionByDateTime(dateTime: LocalDateTime): Question { // 입력된 dateTime이 밤 10시 이후인지 확인