Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The /s/s/ page that was designed to be inside a frame needs to be updated slightly #3147

Open
ckjpn opened this issue Dec 6, 2024 · 0 comments
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.

Comments

@ckjpn
Copy link

ckjpn commented Dec 6, 2024

The /s/s/ page that was designed to be inside a frame needs to be updated slightly.

The reason is that since the page was designed, browsers, for security reasons, have made it so being within a frame means the user is not logged in.

If someone could do this, I'd appreciate it.

There are 2 ways to solve this problem. Number one is perhaps the best way. Number two would be very easy to do.

1. Insert target="_blank" into the link

Insert the following in the link and leave the "Click the top sentence to go to tatoeba.org ..." line in at the bottom of the page.

target="_blank"

This will put the full page into a different tab or window, so logged-in members can add translations or leave comments.

In other words, insert it between...
THIS: <a
AND THIS: href="/en/sentences/show/
So it will look like the following on the https://tatoeba.org/en/s/s/388848 .

<a target="_blank" href="/en/sentences/show/388848"

2. Or, Remove the following from the bottom of the page, so members won't try to click the link to add a translation.

Click the top sentence to go to tatoeba.org to translate it or leave a comment.

Here is a sample use of these pages within a frame.

https://aitech.ac.jp/~english/rndaudio/

You can see what happens when the top sentence is clicked. The member seems to get logged out.

@ckjpn ckjpn added the bug Issue that describes a problem with a feature that doesn't work as expected. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

1 participant