Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it so Admins can remove lists by spammers #3134

Open
ckjpn opened this issue Jul 27, 2024 · 8 comments
Open

Make it so Admins can remove lists by spammers #3134

ckjpn opened this issue Jul 27, 2024 · 8 comments
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.

Comments

@ckjpn
Copy link

ckjpn commented Jul 27, 2024

Make it so Admins can delete empty lists by spammers, since often the list name itself is spam.

Perhaps this is not a priority to do, but it might help let people know that admins monitor incoming spam and take care of it, and help keep things clean and neat.

Notes

  • Even when the spam sentences have been deleted, the list remains.
  • If a list contains no items, there should be no problem with deleting it.
  • If you are worried that an Admin might accidentally delete a "good" list, perhaps the lists could be "unlisted" or set to the current "private" setting. Maybe the "private" setting means that it's not even included in the exported data. I'm not sure.

Example Screenshot

Screenshot 2024-07-28 at 8 36 46
@ckjpn ckjpn added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label Jul 27, 2024
@jiru
Copy link
Member

jiru commented Aug 12, 2024

Private lists are excluded from the weekly export, while unlisted lists are included.

@jiru
Copy link
Member

jiru commented Sep 9, 2024

If you are worried that an Admin might accidentally delete a "good" list, perhaps the lists could be "unlisted" or set to the current "private" setting. Maybe the "private" setting means that it's not even included in the exported data. I'm not sure.

I was about to say yes, better allow admins to "set private" rather than remove the list, but this creates another problem: once the list is set to private, even admins cannot see it any more, so there is no interface available for them to further interact with the list. So if an admin accidentally sets a list to "private", she cannot revert that action.

I think a reasonable solution is to allow admins to delete lists that are empty, @ckjpn what do you think?

@ckjpn
Copy link
Author

ckjpn commented Sep 10, 2024

I think a reasonable solution is to allow admins to delete lists that are empty, @ckjpn what do you think?

I agree.

Perhaps it would even be possible to have spammers' empty lists automatically deleted.
Even if a member got accidentally set to spammer temporarily, losing an empty list wouldn't be a big loss.

@ckjpn
Copy link
Author

ckjpn commented Sep 25, 2024

Note that many of the lists at the top of "browse by list" (https://tatoeba.org/en/sentences_lists/index) are now such lists.
All the ones in the screenshot with zero (0) entries are such lists.

Perhaps if it's not easy to make it so admins can remove these lists via a web interface, maybe someone with direct access to the database, could either delete these or set them to "private" which would hide them from people using the website.

This would (1) make the site look better to vistors and (2) would perhaps make it less likely that others would do the same thing. (reference: https://en.wikipedia.org/wiki/Broken_windows_theory)

https://tatoeba.org/en/sentences_lists/index
Screenshot 2024-09-25 at 16 17 17

@cblanken
Copy link
Contributor

cblanken commented Oct 8, 2024

It probably makes sense to hide any empty lists on the public lists page anyway. That would be easy to implement and a good first step I think.

Perhaps it would even be possible to have spammers' empty lists automatically deleted.
Even if a member got accidentally set to spammer temporarily, losing an empty list wouldn't be a big loss.

Is there any reason it wouldn't be safe to have a cleanup job delete any lists with zero sentences that haven't been updated in a year for example? Empty and idle lists are just a waste of space right? Even if they aren't from a spammer. That way the database is kept cleaner without as much manual intervention needed from the admins.

@jiru
Copy link
Member

jiru commented Oct 12, 2024

maybe someone with direct access to the database, could

For starters I unlisted all visible and empty lists created by suspended users. For reference the query I used was

update sentences_lists
set visibility = 'unlisted'
where user_id in (select id from users where role = 'spammer') and numberOfSentences = 0 and visibility in ('listed','public');

41 lists were affected.

@jiru
Copy link
Member

jiru commented Oct 12, 2024

@cblanken Can you clarify how does your suggestion of removing empty lists after a year help solving the problem of getting rid of spam lists?

@cblanken
Copy link
Contributor

@cblanken Can you clarify how does your suggestion of removing empty lists after a year help solving the problem of getting rid of spam lists?

It wouldn't per se. Just reduce the maintenance burden on admins. Although, if there were only 41 lists anyway, it doesn't make much difference I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Projects
None yet
Development

No branches or pull requests

3 participants