Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an all_sentences_with_audio.tar.bz2, or put all sentences with audio in sentences_with_audio.tar.bz2 . #2955

Closed
ckjpn opened this issue Jun 12, 2022 · 10 comments
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Milestone

Comments

@ckjpn
Copy link

ckjpn commented Jun 12, 2022

Since https://downloads.tatoeba.org/exports/sentences_with_audio.tar.bz2 no longer has all sentences with audio, could you please create another file each week that is similar to this, but that includes all sentences with audio files?

Maybe you could call it all_sentences_with_audio.tar.bz2, Or, perhaps you could just include all sentences with audio like the file used to be.

In addition to what I need, sharptoothed's page relies on this information.

https://tatoeba.j-langtools.com/userchart/chart2.php

@ckjpn ckjpn added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label Jun 12, 2022
@jiru
Copy link
Member

jiru commented Jun 14, 2022

I apologize for all the trouble caused because of that change.

I think it’s fine to include all audios back in the export file. The rationale behind this change was that audio that cannot be reused outside Tatoeba don’t need to be exported, but I didn’t think about reusing the metadata instead. We can just revert most of #2937.

jiru added a commit that referenced this issue Jun 19, 2022
This reverts commits 09f39fd
and 63c3170.

The rationale behind the original change was that audio that cannot
be reused outside Tatoeba don’t need to be exported, but I didn’t
think about reusing the metadata instead. It turns out I broke
some of our members’ workflow, so I’m reverting.

Solves #2955.
@jiru jiru added this to the 2022-06-19 milestone Jun 19, 2022
@jiru
Copy link
Member

jiru commented Jun 19, 2022

Next Saturday’s export will include all sentences with audio, like it used to be.

@jiru jiru closed this as completed Jun 19, 2022
@ckjpn
Copy link
Author

ckjpn commented Jun 22, 2022 via email

@trang
Copy link
Member

trang commented Jun 22, 2022

@ckjpn Did the audio get uploaded after all? I'm not seeing any audio to import on https://tatoeba.org/en/audio/import.

FYI there's been a Tatoeba update today that impacts audio uploads among other things (#2929). When I deployed the changes, there was some issues at first that I didn't notice right away. I needed to run some database migration but wasn't aware. I found out later on and fixed the issues. Perhaps you tried to upload the audio files while it was not fixed yet.

@ckjpn
Copy link
Author

ckjpn commented Jun 22, 2022 via email

@ckjpn
Copy link
Author

ckjpn commented Jun 22, 2022 via email

@ckjpn
Copy link
Author

ckjpn commented Jun 25, 2022 via email

@trang
Copy link
Member

trang commented Jun 25, 2022

@ckjpn There could be something still misconfigured. I will look into it later.

@trang
Copy link
Member

trang commented Jun 26, 2022

@ckjpn It should no longer take several minutes to upload audio. The cause is explained in #2965. If you still experience issues with audio taking several minutes to upload, please report them in #2965.

@ckjpn
Copy link
Author

ckjpn commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Projects
None yet
Development

No branches or pull requests

3 participants