Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile affects sentence translations view #2829

Closed
amkisko opened this issue Aug 14, 2021 · 2 comments
Closed

User profile affects sentence translations view #2829

amkisko opened this issue Aug 14, 2021 · 2 comments
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.

Comments

@amkisko
Copy link

amkisko commented Aug 14, 2021

Sentence translations are not visible while user is logged in

To Reproduce
Steps to reproduce the behavior:

  1. Register
  2. Fill profile languages with some (more than one)
  3. Click 'Translate sentences' and fill in main language and select option to show sentences that are not translated to the next selected language
  4. Go to 'Show random sentence' page
  5. Translations are randomly shown or never shown, one can check it by clicking random sentence and viewing 'Logs' card that clearly states that the sentence is linked somewhere else, but it is not visible on previous screen.

If one logs out it starts working "as expected": all translations/connections are visible.

Expected behavior
All translations should be visible OR there should be a checkbox that will clearly indicate that translations are filtered by some criteria or not shown

Screenshots
That's what happens when user is logged in:
Screenshot 2021-08-14 at 14 14 35

This is expected and works only when user not logged in:
Screenshot 2021-08-14 at 14 14 56

@amkisko amkisko added the bug Issue that describes a problem with a feature that doesn't work as expected. label Aug 14, 2021
@Yorwba
Copy link
Contributor

Yorwba commented Aug 14, 2021

The sentence in your first screenshot is #8017397, which does not have any translations and never had, so that's not a good example.

Looking at what I assume is your profile, it seems like you set your translation languages to "fin" only, which means that you won't be shown any translations in languages other than Finnish, as explained on the settings page.

So the underlying problems I see here are:

  1. It's possible to enable this setting while thinking that you're entering your profile languages.
  2. When this setting is enabled, there's no indicator to show that some translations are hidden.

This might eventually be solved by #2791.

@amkisko
Copy link
Author

amkisko commented Aug 14, 2021

Looking at what I assume is your profile, it seems like you set your translation languages to "fin" only

Thanks and sorry for that confusion, I didn't read it carefully. This story can be closed. :)

@amkisko amkisko closed this as completed Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

2 participants