Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate whether migration from lynxtray(infi.systray) to pytray makes sense #1355

Closed
C0rn3j opened this issue Dec 22, 2024 · 4 comments
Closed

Comments

@C0rn3j
Copy link
Collaborator

C0rn3j commented Dec 22, 2024

infi.systray is dead, we were using it for Windows systray.

I have forked it as lynxtray and fixed the glaring issues that were spamming the log, and we now use that.

There is however pystray, which is cross-platform for macOS/Windows/Linux(X only??) - https://github.com/moses-palmer/pystray - it looks similarly dead, but it may make sense to switch to fork it and switch to it.

If we stay with the infi.systray fork, it makes sense to go through https://github.com/Infinidat/infi.systray/pulls and issues and take what's useful.

@Taiko2k
Copy link
Owner

Taiko2k commented Dec 22, 2024

lynxtray would be easier since its already implemented.

My feeling is to avoid a cross platform lib on Linux as Linux support is intended to be first class. (i.e if there's any potential sacrifice to feature support then I'd rather not use a cross-platform lib there)

@Solarunit
Copy link

Solarunit commented Dec 22, 2024

My feeling is to avoid a cross platform lib on Linux as Linux support is intended to be first class. (i.e if there's any potential sacrifice to feature support then I'd rather not use a cross-platform lib there)

Thanks for the first class Linux support! ❤️ 🐧 🎧

@C0rn3j
Copy link
Collaborator Author

C0rn3j commented Dec 22, 2024

My feeling is to avoid a cross platform lib on Linux as Linux support is intended to be first class.

We can use the lib only on Windows (and possibly macOS) if necessary.

pystray does not seem to have support for the dbus-based SNI anyway, so we would not be fixing much with it on the Linux side, as #1316 would still need to be resolved.

The question is if pystray has better functionality for Windows over the now-forked lynxtray

@C0rn3j
Copy link
Collaborator Author

C0rn3j commented Dec 28, 2024

Gonna close this, can be revisited later if needed, seems to work for now.

@C0rn3j C0rn3j closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants