Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the JavaScript linting more strict #1397

Open
cumuru opened this issue Jul 30, 2024 · 0 comments
Open

Make the JavaScript linting more strict #1397

cumuru opened this issue Jul 30, 2024 · 0 comments
Labels
task
Milestone
4.0.0: Breaking c...

Comments

@cumuru
Copy link
Contributor

cumuru commented Jul 30, 2024 •
edited
Loading

The JavaScript linting as run by runTests.sh -s lintJs is very lax. Only syntax errors seem to be considered. Code style violations such as two statements per line, missing semicolon, etc. are ignored.

Suggested steps:

  1. Define desired rules
  2. Configure ruleset for eslint
  3. Verify with violations
@cumuru cumuru added task feedback Some kind of feedback from outside to the team labels Jul 30, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Jul 30, 2024
@oliverklee oliverklee removed the feedback Some kind of feedback from outside to the team label Jul 30, 2024
@oliverklee oliverklee changed the title JavaScript linting is very lax Make the JavaScript linting more strict Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

No branches or pull requests
2 participants
@oliverklee @cumuru