Merge pull request #26 from TNG/MOMO-14-improve-eslint

Momo 14 improve eslint

.eslintrc.js

@@ -1,24 +1,216 @@
 module.exports = {
-  env: {
-    es6: true,
-    node: true,
-  },
-  extends: ['plugin:prettier/recommended', 'plugin:jest/recommended'],
+  env: { es6: true, node: true },
+  extends: ['plugin:jest/recommended', 'plugin:prettier/recommended'],
   parser: '@typescript-eslint/parser',
   parserOptions: {
     project: 'tsconfig.eslint.json',
     sourceType: 'module',
   },
+  plugins: [
+    '@typescript-eslint',
+    'eslint-plugin-import',
+    'eslint-plugin-jsdoc',
+    'eslint-plugin-prefer-arrow',
+    'sort-imports-es6-autofix',
+  ],
   rules: {
+    '@typescript-eslint/adjacent-overload-signatures': 'error',
+    '@typescript-eslint/array-type': [
+      'error',
+      {
+        default: 'array',
+      },
+    ],
+    '@typescript-eslint/dot-notation': 'error',
+    '@typescript-eslint/member-delimiter-style': [
+      'error',
+      {
+        multiline: {
+          delimiter: 'semi',
+          requireLast: true,
+        },
+        singleline: {
+          delimiter: 'semi',
+          requireLast: false,
+        },
+      },
+    ],
+    '@typescript-eslint/naming-convention': [
+      'error',
+      {
+        selector: 'default',
+        format: ['camelCase'],
+        leadingUnderscore: 'allow',
+        trailingUnderscore: 'forbid',
+      },
+      {
+        selector: 'variable',
+        format: ['camelCase', 'UPPER_CASE'],
+        leadingUnderscore: 'allow',
+        trailingUnderscore: 'forbid',
+      },
+      {
+        selector: 'enumMember',
+        format: ['camelCase', 'UPPER_CASE'],
+      },
+      {
+        selector: 'typeLike',
+        format: ['PascalCase'],
+      },
+    ],
+    '@typescript-eslint/no-empty-function': 'error',
+    '@typescript-eslint/no-empty-interface': 'error',
+    '@typescript-eslint/no-explicit-any': 'error',
+    '@typescript-eslint/no-floating-promises': 'error',
+    '@typescript-eslint/no-for-in-array': 'error',
+    '@typescript-eslint/no-misused-new': 'error',
+    '@typescript-eslint/no-namespace': 'error',
+    '@typescript-eslint/no-parameter-properties': 'off',
+    '@typescript-eslint/no-this-alias': 'error',
+    '@typescript-eslint/no-unnecessary-condition': 'error',
+    '@typescript-eslint/no-unnecessary-qualifier': 'error',
+    '@typescript-eslint/no-unnecessary-type-arguments': 'error',
+    '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+    '@typescript-eslint/no-unused-expressions': 'error',
+    '@typescript-eslint/no-use-before-define': 'off',
+    '@typescript-eslint/no-var-requires': 'error',
+    '@typescript-eslint/prefer-for-of': 'error',
+    '@typescript-eslint/prefer-function-type': 'error',
+    '@typescript-eslint/prefer-namespace-keyword': 'error',
+    '@typescript-eslint/prefer-readonly': 'error',
+    '@typescript-eslint/promise-function-async': 'error',
+    '@typescript-eslint/quotes': ['error', 'single', { avoidEscape: true, allowTemplateLiterals: true }],
+    '@typescript-eslint/restrict-plus-operands': 'error',
+    '@typescript-eslint/semi': 'error',
+    '@typescript-eslint/strict-boolean-expressions': [
+      'error',
+      {
+        allowNullableObject: true,
+        allowNullableBoolean: false,
+        allowNullableString: false,
+      },
+    ],
+    '@typescript-eslint/triple-slash-reference': [
+      'error',
+      {
+        path: 'always',
+        types: 'prefer-import',
+        lib: 'always',
+      },
+    ],
+    '@typescript-eslint/explicit-function-return-type': [
+      'error',
+      {
+        allowExpressions: true,
+        allowTypedFunctionExpressions: true,
+        allowHigherOrderFunctions: true,
+        allowDirectConstAssertionInArrowFunctions: false,
+        allowConciseArrowFunctionExpressionsStartingWithVoid: false,
+      },
+    ],
+    '@typescript-eslint/type-annotation-spacing': 'error',
+    '@typescript-eslint/unified-signatures': 'error',
+    'arrow-parens': ['error', 'always'],
+    'brace-style': 'error',
     'comma-dangle': ['error', 'always-multiline'],
+    complexity: 'off',
+    'constructor-super': 'off',
+    'eol-last': 'error',
+    eqeqeq: ['error', 'smart'],
+    'guard-for-in': 'error',
+    'id-blacklist': [
+      'error',
+      'any',
+      'Number',
+      'number',
+      'String',
+      'string',
+      'Boolean',
+      'boolean',
+      'Undefined',
+      'undefined',
+    ],
+    'id-match': 'error',
+    'import/no-cycle': 'error',
+    'import/no-deprecated': 'error',
+    'import/no-extraneous-dependencies': 'off',
+    'import/no-internal-modules': ['error', { allow: ['**/*', '**/src/*'] }],
+    'import/no-restricted-paths': ['error', { zones: [{ target: './src', from: './test' }] }],
+    'import/order': [
+      'error',
+      {
+        groups: ['builtin', 'external', 'object'],
+      },
+    ],
     'jest/expect-expect': [
       'error',
       {
-        assertFunctionNames: ['expect*', 'verify'],
+        assertFunctionNames: ['expect*', 'verify*'],
       },
     ],
+    'jsdoc/check-alignment': 'error',
+    'jsdoc/check-indentation': 'error',
+    'jsdoc/newline-after-description': 'error',
+    'linebreak-style': 'error',
+    'max-classes-per-file': 'off',
+    'max-len': 'off',
+    'new-parens': 'off',
+    'newline-per-chained-call': 'off',
+    'no-bitwise': 'error',
+    'no-caller': 'error',
+    'no-cond-assign': 'error',
+    'no-console': 'error',
+    'no-debugger': 'error',
+    'no-duplicate-case': 'error',
+    'no-duplicate-imports': 'error',
+    'no-empty': 'error',
+    'no-eval': 'error',
+    'no-extra-bind': 'error',
+    'no-extra-semi': 'error',
+    'no-fallthrough': 'error',
+    'no-invalid-this': 'off',
+    'no-irregular-whitespace': 'error',
+    'no-multiple-empty-lines': 'error',
+    'no-new-func': 'error',
+    'no-new-wrappers': 'error',
+    'no-redeclare': 'error',
+    'no-return-await': 'error',
+    'no-sequences': 'error',
+    'no-sparse-arrays': 'error',
+    'no-template-curly-in-string': 'error',
+    'no-throw-literal': 'error',
+    'no-trailing-spaces': 'error',
+    'no-undef-init': 'error',
+    'no-unsafe-finally': 'error',
+    'no-unused-labels': 'error',
+    'no-var': 'error',
+    'no-void': 'error',
+    'object-shorthand': 'error',
+    'one-var': ['error', 'never'],
     'prefer-const': 'error',
-    '@typescript-eslint/strict-boolean-expressions': 'off',
+    'quote-props': ['error', 'as-needed'],
+    radix: 'error',
+    semi: 'off', // use @typescript-eslint/semi instead
+    'sort-imports': ['error', { allowSeparatedGroups: true, ignoreDeclarationSort: true }],
+    'sort-imports-es6-autofix/sort-imports-es6': 'error',
+    'space-before-function-paren': 'off',
+    'space-in-parens': ['error', 'never'],
+    'spaced-comment': [
+      'error',
+      'always',
+      {
+        markers: ['/'],
+      },
+    ],
+    'use-isnan': 'error',
+    'valid-typeof': 'error',
+  },
+  ignorePatterns: ['dist', 'tsconfig.json', 'tsconfig.eslint.json', 'package.json', 'package-lock.json', 'ort'],
+  settings: {
+    'import/resolver': {
+      node: {
+        extensions: ['.ts'],
+      },
+    },
   },
-  ignorePatterns: ['dist', 'tsconfig.json', 'tsconfig.eslint.json'],
 };

.github/workflows/ci.yml

@@ -20,12 +20,12 @@ jobs:
       - run: npm install
       - run: npm run build
 
-  lint-and-test:
+  lint:
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        node: [10, 12, 14, 16]
+        node: [14, 16]
 
     steps:
       - name: Checkout the repository
@@ -36,5 +36,21 @@ jobs:
           node-version: ${{ matrix.node }}
       - run: npm install
       - run: npm run lint
+
+  test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node: [10, 12, 14, 16]
+
+    steps:
+      - name: Checkout the repository
+        uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node }}
+      - run: npm install
       - run: npm run test
       - run: npm run test:integration

.prettierignore

@@ -0,0 +1 @@
+dist