MOMO-14: Added explicit return type to eslint

Signed-off-by: Yani Kolev <[email protected]>

.eslintrc.js

@@ -98,6 +98,16 @@ module.exports = {
         lib: 'always',
       },
     ],
+    '@typescript-eslint/explicit-function-return-type': [
+      'error',
+      {
+        allowExpressions: true,
+        allowTypedFunctionExpressions: true,
+        allowHigherOrderFunctions: true,
+        allowDirectConstAssertionInArrowFunctions: false,
+        allowConciseArrowFunctionExpressionsStartingWithVoid: false,
+      },
+    ],
     '@typescript-eslint/type-annotation-spacing': 'error',
     '@typescript-eslint/unified-signatures': 'error',
     'arrow-parens': ['error', 'always'],

src/logging/Logger.ts

@@ -8,7 +8,7 @@ export interface Logger {
   error: (message: string, type: MomoErrorType, data?: MomoEventData, error?: Error) => void;
 }
 
-export function debug(this: TypedEmitter<MomoEvents>, message: string, data?: MomoEventData) {
+export function debug(this: TypedEmitter<MomoEvents>, message: string, data?: MomoEventData): void {
   this.emit('debug', { message, data });
 }
 
@@ -18,6 +18,6 @@ export function error(
   type: MomoErrorType,
   data?: MomoEventData,
   error?: Error
-) {
+): void {
   this.emit('error', { message, type, data, error });
 }

src/repository/ExecutionsRepository.ts

@@ -12,7 +12,7 @@ export class ExecutionsRepository extends MongoRepository<ExecutionsEntity> {
     await this.save(new ExecutionsEntity(scheduleId, DateTime.now().toMillis(), {}));
   }
 
-  async removeJob(scheduleId: string, name: string) {
+  async removeJob(scheduleId: string, name: string): Promise<void> {
     const executionsEntity = await this.findOne({ scheduleId });
     if (executionsEntity === undefined) {
       throw new Error(`executionsEntity not found for scheduleId=${scheduleId}`);

src/repository/JobRepository.ts

@@ -16,7 +16,10 @@ export class JobRepository extends MongoRepository<JobEntity> {
   }
 }
 
-function merge(savedJob: JobEntity, { interval, concurrency, maxRunning, executionInfo }: Partial<JobEntity>) {
+function merge(
+  savedJob: JobEntity,
+  { interval, concurrency, maxRunning, executionInfo }: Partial<JobEntity>
+): JobEntity {
   if (interval !== undefined) {
     savedJob.interval = interval;
   }

test/job/findLatest.spec.ts

@@ -5,7 +5,7 @@ import { Job } from '../../src/job/Job';
 import { JobEntity } from '../../src/repository/JobEntity';
 import { findLatest } from '../../src/job/findLatest';
 
-function createJob(lastFinished?: number) {
+function createJob(lastFinished?: number): JobEntity {
   const job = JobEntity.from({ name: 'test' } as Job);
   if (lastFinished !== undefined) {
     job.executionInfo = { lastFinished: DateTime.fromMillis(lastFinished).toISO() } as ExecutionInfo;

test/utils/logging.ts

@@ -8,7 +8,7 @@ import { MomoEventData, MomoEvents } from '../../src/logging/MomoEvents';
 const logger = Pino();
 const errorLogger = Pino({ level: 'error' });
 
-export function initLoggingForTests(eventEmitter: TypedEmitter<MomoEvents>) {
+export function initLoggingForTests(eventEmitter: TypedEmitter<MomoEvents>): void {
   eventEmitter.on('debug', (event) => {
     logger.info(event);
   });