Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with velocity inputs (instead of just water mass transport) #3

Open
briochemc opened this issue Sep 27, 2024 · 4 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@briochemc
Copy link
Member

briochemc commented Sep 27, 2024

Right now I use umo and vmo (mass transport in kg/s IIRC). Sometimes CMIP output only include uo and vo (velocities in m/s). It would be good to be able to deal with these too.

I think this just needs a conversion to mass transport using seawater density and cell face areas?

@briochemc briochemc added the enhancement New feature or request label Sep 27, 2024
@briochemc briochemc self-assigned this Sep 27, 2024
@briochemc
Copy link
Member Author

Draft implemented in 7ac2be1. Should add better tests and visualize difference between using (umo,vmo) vs (uo,vo) locally as well.

@briochemc
Copy link
Member Author

Visual tests show it's not working. I need to "regrid" the B-grid uo,vo to the C-grid u,v positions to match the C-grid umo/vmo positions of the tests.

@briochemc
Copy link
Member Author

@briochemc
Copy link
Member Author

briochemc commented Oct 4, 2024

Partial solution in 05f604c for ACCESS at least (uo/vo on B-grid vs umo/vmo on C-grid). There is still some difference, but I'm unsure how to deal with it. Maybe it has to do with the orientation where instead of the area derived from the cell thickness I should instead use the upstream cell thickness, or use the mean or the minimum of both directions, or maybe it's non-rectangular vertical face shapes, or density? The right way to check would be to dive into the MOM code... 😨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant