Update camera's screen size on update() instead of previous draw() #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This ensures that, by the next Sector::draw(), the camera has been updated to use the current screen size, instead of that from the previous frame.
mstoeckl
force-pushed
the
camera-direct-load-size
branch
from
ee49072 to
dfb5936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensure the screen size used in Camera::update() will match that used by the next ::draw(), instead of sometimes being one frame behind when the SuperTux window is resized. They also may ensure that when the scale is being changed over time, the scale-divided screen size observed by Squirrel will update more frequently. By reducing the number of public functions which can modify the Camera state, they should make Camera very slightly easier to refactor.