Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 1 method name in Block Init.php #62

Open
plhubert-tbd opened this issue Aug 7, 2020 · 1 comment
Open

Magento 1 method name in Block Init.php #62

plhubert-tbd opened this issue Aug 7, 2020 · 1 comment

Comments

@plhubert-tbd
Copy link

     * @return bool|false
     */
    public function getLoaderImage()
    {
        $url = $this->getScrollConfig('design/loading_img');

        if (!empty($url)) {
            $url = strpos($url, 'http') === 0 ? $url : $this->getSkinUrl($url);
        }
        return empty($url) ? false : $url;
    }

You should use $this->getViewFileUrl($url) instead of $this->getSkinUrl($url).

Pierre-Louis

@gsomoza
Copy link
Member

gsomoza commented Aug 11, 2020

Thanks @plhubert-tbd – any chance you'd consider making a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants