Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASET ERS props to ASET-Consolidated-Props #26

Open
kurgut opened this issue Dec 5, 2023 · 5 comments
Open

Add ASET ERS props to ASET-Consolidated-Props #26

kurgut opened this issue Dec 5, 2023 · 5 comments

Comments

@kurgut
Copy link

kurgut commented Dec 5, 2023

I noticed ASET ERS comes with 2 very nice props, the ERSDriveMonitorScreen and ERSPitchRollDisplay.
Would it be possible, if modders (like me right now ^^) would like to include those props in their IVA, to include them to Aset-Props ?
To avoid adding ERS as a dependency for the user.
So maybe it would require to take those props out of ERS, so they're not duplicated.
I guess I'll issue on ERS too and link it to here..
Thank you !

@kurgut kurgut changed the title Add ASET PRS props to ASET-Consolidated-Props Add ASET ERS props to ASET-Consolidated-Props Dec 5, 2023
@linuxgurugamer
Copy link

The ERS license is an CC-SA-NC, so I would say, go ahead. I would suggest making sure there aren't any name collisions, and be sure to reference the contributions from ERS

@JonnyOThan
Copy link
Collaborator

JonnyOThan commented Dec 5, 2023

I think those props have textures that are pretty specific to the ERS, right? Sure they're kinda useful in other rovers though. And maybe eventually they can be generalized (which would certainly be something that ASET props would be interested in).

I think the right path forward here is:

  1. ASET_Props adds these files to its repo, and makes sure all of them have :NEEDS[!ASET/ERS/Props/ERSDriveMonitor] etc, so that they are disabled when ERS provides those props itself.
  2. At some point in the future, ERS can remove the props

Sound good @linuxgurugamer ?

Ehh but I'm kinda questioning how useful this is without some way to change the textures. There is a non-zero cost to the user to moving this over in terms of models, textures, RPM custom variables, etc. It's probably not huge but there's also no benefit until other IVAs start using them. Can you share more about your plans @kurgut ?

Maybe a better path for you would be to create new versions of these props, using the ERS ones as a starting point, and just give attribution?

@linuxgurugamer
Copy link

Fine by me, but I'm not planning on making any changes to ERS. Sounds like these changes are all on the Props side

@kurgut
Copy link
Author

kurgut commented Dec 5, 2023

Can you share more about your plans @kurgut ?

I was planning implementing them in the External Command Seat IVA mod I started working on, which would include a rover variant, with those props.
Also on a high tech flavor version of PCR.

Maybe a better path for you would be to create new versions of these props, using the ERS ones as a starting point, and just give attribution?

I'm fine with that too

@JonnyOThan
Copy link
Collaborator

Yeah, I think just building new rover hud props that are designed to be generalized for all rovers is the right move, and I'd be happy to include them in ASET if you want. Sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants