Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config keys are exposed in github, direction needed for personal repositories #3

Open
gnmonsour opened this issue Dec 2, 2020 · 1 comment

Comments

@gnmonsour
Copy link

The config folder is checked in to github and visible to all. Shouldn't students be directed to alter their gitignore content to not check in that folder?

@erkjbro
Copy link

erkjbro commented Jan 20, 2021

The dev.js file is listed in gitignore. He also explains that students shouldn't check the file in during his course. The file itself has a warning about this also. It's basically just a reference.

Although it's probably good to ignore ci.js as well? Unless it was altered to work similarly to the prod.js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants