-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of snap cursor and snapping in wire-draw mode #292
Comments
I have created the I have added a couple of small fixes Chayan could look at (double to int conversion in for merging into my master tree I suggest 2 things:
For wiring in persistent mode, if a wire placement is in progress the first escape clears the last wire placement, but wire insert mode is still active. A second escape clears the command completely. This is consistent with other commands, for example if you select some objects and press 'm'/'c' to move/copy and you press Escape before confirming the move/copy operation the move is cancelled, but the selection is still active. A second Escape clears the selection. I am keeping the SuperChayan branch updated and when the changes will not pull the carpet under existing user feets I can apply the merge. Thank you. |
Sincerely appreciate this Stefan. We'll implement your suggestions. Re congrats to Chayan, I tried myself, but couldn't get anywhere, so I was lucky to find him 😊 I know what you mean. We should keep up the momentum. If it goes well, we can look into raising funds to get open-access (OA) support. Then, work done in Xschem can be imported into Cadence. But, before that, we should give some thought to refactoring the code so more developers can get involved easily. "SOLID" principles are what I am thinking of - SRP - single responsibility, OCP - Open-for-extension/Closed for Modification, LIskov substitution (may not apply), Interface Segregation - may not apply, Dependency Inversion - could be considered.. |
…t', which can be enabled from either the TCL-command execution prompt inside xschem, or by uncommenting the corresponding option in 'src/xschemrc' - used for enabling Cadence-friendly keybinds (simulate and snap-wire). Additionally, reset the default behavior of xschem to the upstream-version's behavior. All the disabled options can be re-enabled by uncommenting the correct options in 'src/xschemrc'. Added ANSI-C compatibility fixes suggested by @StefanSchippers in issue StefanSchippers#292 in upstream repo.
Please consider merging this feature from this repo as it provides the same user experience as Cadence ('s' to snap. CTRL-r now for run simulation):
https://github.com/TheSUPERCD/xschem
The changes are described here : https://docs.google.com/document/d/1ETLK9iiXGWEOvRR4gzMR80oQV1wyVk8h4_TlROCo8t0/edit?tab=t.0
The text was updated successfully, but these errors were encountered: