Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent org/organization usage #1431

Open
bart-vmware opened this issue Jan 14, 2025 · 2 comments
Open

Inconsistent org/organization usage #1431

bart-vmware opened this issue Jan 14, 2025 · 2 comments
Labels
Component/Security Issues related to Steeltoe Security components (not app-sec) Type/code-quality Issue that affects code quality Warn/breaking-change There is a breaking change in the code
Milestone

Comments

@bart-vmware
Copy link
Member

Searching the codebase, we have:

  • AddOrgAndSpacePolicies
  • CertificateAuthorizationPolicies.SameOrganization

The public API surface, comments and internals should be updated to reflect a single style.
I suggest spelling out "organization" everywhere.

@bart-vmware bart-vmware added Warn/breaking-change There is a breaking change in the code Type/code-quality Issue that affects code quality Component/Security Issues related to Steeltoe Security components (not app-sec) labels Jan 14, 2025
@bart-vmware bart-vmware added this to the 4.0.0-m1 milestone Jan 14, 2025
@TimHess
Copy link
Member

TimHess commented Jan 16, 2025

Hmm... I would generally prefer to use "Org" since (in my experience) that's how it's most commonly referred to... some examples:

But the identity certificates definitely do use organization= (Steeltoe code for parsing the certs)

@bart-vmware
Copy link
Member Author

I agree we should go with "org", as that seems to be the conceptual name in use. The OU in the certificate is an implementation detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Security Issues related to Steeltoe Security components (not app-sec) Type/code-quality Issue that affects code quality Warn/breaking-change There is a breaking change in the code
Projects
None yet
Development

No branches or pull requests

2 participants