Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove left-overs from .NET Framework observers #1423

Closed
bart-vmware opened this issue Jan 9, 2025 · 0 comments · Fixed by #1454
Closed

Remove left-overs from .NET Framework observers #1423

bart-vmware opened this issue Jan 9, 2025 · 0 comments · Fixed by #1454
Assignees
@TimHess
Labels
Component/Management Issues related to Steeltoe Management (actuators) Type/bug Something isn't working
Milestone
4.0.0-m1

Comments

@bart-vmware
Copy link
Member

bart-vmware commented Jan 9, 2025 •
edited
Loading

The observer for legacy outgoing HTTP requests on .NET Framework was removed, but there are still references to it, such as here.

The MetricsObserverOptions.HttpClientDesktop property should be removed.

May also rename MetricsObserverOptions.HttpClientCore to just .HttpClient and update its comment. Doing so is a breaking change, though.

Also, this looks broken:

"HttpClientCoreObserver" => HttpClientCore,

Because the type is named HttpClientObserver. It looks like there aren't any tests for it.
@bart-vmware bart-vmware added Type/bug Something isn't working Component/Management Issues related to Steeltoe Management (actuators) labels Jan 9, 2025
@bart-vmware bart-vmware mentioned this issue Jan 9, 2025
Open
@TimHess TimHess self-assigned this Jan 30, 2025
@TimHess TimHess added this to the 4.0.0-m1 milestone Jan 30, 2025
@TimHess TimHess mentioned this issue Jan 30, 2025
Merged
5 tasks
@TimHess TimHess linked a pull request Jan 30, 2025 that will close this issue
Remove metrics endpoint #1454
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimHess TimHess

Labels
Component/Management Issues related to Steeltoe Management (actuators) Type/bug Something isn't working
Projects
None yet
Milestone
4.0.0-m1
Development

Successfully merging a pull request may close this issue.

Remove metrics endpoint SteeltoeOSS/Steeltoe
2 participants
@TimHess @bart-vmware