Kubeflow 1.3 Upgrade: Local testing

[skyeturriff]

Local testing before getting it into dev.

Linked with #833

We're doing it as a separate issue as more effort is required to investigate why build tests are failing, and to build a successful image for deployment into local kubeflow cluster (following these instructions)

[skyeturriff]

Running npm test fails with the error

on merge branch, but not on upstream's v1.3 branch.

Running npx eslint --print-config main-page.js on both produces vastly different eslint configs. Namely of note on merge branch, the resulting config file includes:

"no-prototype-builtins": [
      "error"
],

While on upstream, the resulting config file has:

"no-prototype-builtins": "off",

The project's eslintrc.json config files (found in the centraldashboard/ and centraldashboard/public/ directories) on the merge branch and the upstream branch are identical.

[skyeturriff]

Changing eslint version in package.json to match the versions used on upstream's v1.3 branch allows npm test to compile successfully, and results in npx eslint --print-config main-page.js generating an identical config to that of upstream

Versions that appeared on merge branch after the merge, where npm test fails:

"eslint": "^7.7.0",
"eslint-config-google": "^0.12.0",
"eslint-loader": "^4.0.2",
"eslint-plugin-jasmine": "^2.10.1",

Versions on upstream v1.3 branch, when used on merge branch allows npm test to succeed:

"eslint": "^5.16.0",
"eslint-config-google": "^0.12.0",
"eslint-loader": "^2.2.1",
"eslint-plugin-jasmine": "^2.10.1",

[wg102]

Some tests needed to be adjusted following kubeflow/kubeflow@876016a

Tehre is still one test failing, the activities-litst_test.js Show Activities in descending by lastTimesStamp

[skyeturriff]

Tests pass and image builds!

[skyeturriff]

Build image has issues with i18n. Causing errors with the menuLinks.

Meanwhile, TODOs (from parent):

• Investigate if Central Dashboard Controller is a different offshoot of upstream's and port over any changes (also look into Manage Contributors)
• Confirm changes from March 24 commit are implemented in our fork ( feat(profile-controller): add pipelines.kubeflow.org/enabled label to namespaces # 5762 )

To look for in the UI walkthrough (once testable image is available):

• i18n (test in french as well)
• Manage Contributors => also good idea to create second namespace and test this
• Menu items (Make sure current page is bolded in side menu (main-page.pug))
• Documentation items
• Remove Volume Web Apps from side menu