From 62a46698d0146a6fdbb93d92a8e0907069eb0a63 Mon Sep 17 00:00:00 2001 From: Jordi Mas Date: Sun, 4 Aug 2024 13:15:54 +0200 Subject: [PATCH] Simplify code in filesets --- src/builder/bazaarfileset.py | 7 +------ src/builder/compressedfileset.py | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/builder/bazaarfileset.py b/src/builder/bazaarfileset.py index f63c22db..379d02c5 100644 --- a/src/builder/bazaarfileset.py +++ b/src/builder/bazaarfileset.py @@ -27,12 +27,7 @@ def _has_filename(self): """Used to identify if the file contains a path (/ and then .)""" filename = self.url.split("/")[-1] - if len(filename) > 0: - rslt = self.filename.find(".") - if rslt != -1: - return True - - return False + return "." in filename def do(self): if self._has_filename(): diff --git a/src/builder/compressedfileset.py b/src/builder/compressedfileset.py index 3f6a03d0..945fbd3b 100644 --- a/src/builder/compressedfileset.py +++ b/src/builder/compressedfileset.py @@ -41,7 +41,7 @@ def uncompress(filename, report_error, temp_dir): cmd = "tar -Jxf {0} -C {1}".format(filename, temp_dir) os.system(cmd) else: - if report_error is True: + if report_error: msg = "Unsupported file extension for filename: {0}" logging.error(msg.format(filename))