Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure list endpoint calls do not set include_* query params #96

Closed
KPreisner opened this issue Mar 21, 2024 · 0 comments · Fixed by #97
Closed

Ensure list endpoint calls do not set include_* query params #96

KPreisner opened this issue Mar 21, 2024 · 0 comments · Fixed by #97
Assignees
@sangaline

Comments

@KPreisner
Copy link
Member

Ensure list endpoint calls do not set include_* query params

See sindri api PR #808
@sangaline sangaline mentioned this issue Mar 25, 2024
Merged
sangaline added a commit that referenced this issue Mar 25, 2024
@sangaline
Remove getAllProofs() and deprecated include_* API parameters
e4c87f9 
This regenerates the internal API client based on recent upstream changes. This
includes making `/api/v1/proof/list` an internal endpoint, adding `public` to
circuit info responses, and various documentation improvements. Because listing
all proofs is now an internal-only method, I removed
`SindriClient.getAllProofs()`. We were using this in the `getProof()` tests, so
these also had to be updated not to use it.

Closes #96
Merges #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaline sangaline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove getAllProofs() and deprecated include_* API parameters Sindri-Labs/sindri-js
2 participants
@sangaline @KPreisner