Add node version testing matrix and specify compatible engines #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a testing matrix that covers node versions 18-21, and specifies the minimum node engine version in
package.jsonas v18.3.0. One blocker to supporting earlier versions is thatbuffer.Filewas added in v18.3.0. I took a stab at removing this, but ran into a lot of issues trying to get things to work without it. v16 was EOLed last year though, so I don't think this is that major of an issue. It will be easier to test against earlier versions now with the testing matrix if we do decide we want to support them.One notable thing is that the
--loadervs--importargument depends on versions in fairly complex ways. I think that it's roughly--importfor>=18.19.0 < 19.0.0 || >=v20.6.0and--loaderfor everything else, and I have a commit in here with something like that working in the ava config, but ultimately went with running ava with tsx liketsx ./node_modules/.bin/avabecause I'm more confident that this will work with any node version (despite the fact that it's a bit hackier).Closes #64