Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify compatible node versions in package.json and add a testing matrix #64

Closed
sangaline opened this issue Jan 22, 2024 · 0 comments · Fixed by #67
Closed

Specify compatible node versions in package.json and add a testing matrix #64

sangaline opened this issue Jan 22, 2024 · 0 comments · Fixed by #67
Assignees
@sangaline

Comments

@sangaline
Copy link
Contributor

No description provided.

@sangaline sangaline self-assigned this Jan 22, 2024
@sangaline sangaline mentioned this issue Jan 31, 2024
Merged
sangaline added a commit that referenced this issue Jan 31, 2024
@sangaline
Add node version testing matrix and specify compatible engines
cabbd99 
This adds a testing matrix that covers node versions 18-21, and specifies the
minimum node engine version in `package.json` as v18.3.0. One blocker to
supporting earlier versions is that `buffer.File` was added in v18.3.0. I took
a stab at removing this, but ran into a lot of issues trying to get things to
work without it. v16 was EOLed last year though, so I don't think this is that
major of an issue. It will be easier to test against earlier versions now with
the testing matrix if we do decide we want to support them.

One notable thing is that the `--loader` vs `--import` argument depends on
versions in fairly complex ways. I think that it's roughly `--import` for
`>=18.19.0 < 19.0.0 || >=v20.6.0` and `--loader` for everything else, and I
have a commit in here with something like that working in the ava config, but
ultimately went with running ava with tsx like `tsx ./node_modules/.bin/ava`
because I'm more confident that this will work with any node version (despite
the fact that it's a bit hackier).

Closes #64
Merges #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaline sangaline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add node version testing matrix and specify compatible engines Sindri-Labs/sindri-js
1 participant
@sangaline