Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Launcher is not setting the NODE_ENV environment variable. #77

Closed
3 tasks done
Cohee1207 opened this issue Sep 25, 2024 · 1 comment
Closed
3 tasks done
Labels
🐛Bug [ISSUE] Ticket describing something that isn't working ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🪟 Windows

Comments

@Cohee1207
Copy link
Member

Environment

🪟 Windows

System

Any Windows

Describe the problem

The startup scripts in the main repo set the NODE_ENV to production.
https://github.com/SillyTavern/SillyTavern/blob/5a4e23f62f12d3b91d01d261d52a3e78abff8492/Start.bat#L3

This doesn't happen when using the launcher.

Additional info

Why is it bad?

  1. The server will report as running in an undefined environment upon startup.
  2. Some libraries may not include additional optimizations that are only activated in production.

How to fix?

Add set NODE_ENV=production at the very start of the launcher.bat or in the server startup string.

Please tick the boxes

@Cohee1207 Cohee1207 added the 🐛Bug [ISSUE] Ticket describing something that isn't working label Sep 25, 2024
@deffcolony
Copy link
Collaborator

@deffcolony deffcolony added the ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug [ISSUE] Ticket describing something that isn't working ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🪟 Windows
Projects
None yet
Development

No branches or pull requests

2 participants