Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable Release (checkout) #2515

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

shopify-github-actions-access[bot]
Copy link
Contributor

@shopify-github-actions-access shopify-github-actions-access bot commented Dec 4, 2024

This PR was opened by the Prepare UI extension release Github Action. It contains the latest changes from the following packages:

Generated at this commit.

When you are ready, you can merge this PR to publish the changes. If you aren't ready to do a release, you can close this PR with a comment.

📝 Instructions

Use this checklist to acknowledge you've gone through the steps required. You can always exclude certain changes, but you should avoid making changes to code in this PR. This should happen within checkout-web only.

  • I have reviewed the changes in this PR and I have checked with the authors of these changes to confirm they should be publicly released.
  • If there is a reason why certain files should be excluded, I have documented this in the PR.
  • I have added a changeset (see adding code for details) for each code change. Documentation changes do not require a changeset.
  • The changes have corresponding documentation, or there are issues logged to add documentation in a future release.
  • I have not changed any code in this PR without having first shipped the same change in checkout-web.

🎩 Tophat

Comment /snapit on this PR to generate a snapshot of this package you can test with a local extension.

  • 🎩 I have tophatted the changes in this PR.

Note: Learn more about tophatting checkout UI extensions.

🚢 Ship it!

Click the Merge button to ship these changes to unstable. The Unstable snapshot Github action will publish the packages for you.

🛟 Need help?

If you have any questions, you can ask in the #help-checkout-extensibility channel on Slack.

Note: You can always do releases manually, following these vault instructions.

This comment has been minimized.

@ryan-ludwig ryan-ludwig requested a review from jffortier December 4, 2024 20:34
@ryan-ludwig
Copy link
Contributor

Going to remove all non ClipboardItem and QRCode changes from this PR.

@ryan-ludwig ryan-ludwig removed the request for review from jffortier December 4, 2024 20:59
@ryan-ludwig
Copy link
Contributor

/snapit

@shopify-github-actions-access
Copy link
Contributor Author

🫰✨ Thanks @ryan-ludwig! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/data-extensions": "0.0.0-snapshot-20241204210106",
"@shopify/ui-extensions": "0.0.0-snapshot-20241204210106",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241204210106"

@ryan-ludwig
Copy link
Contributor

ryan-ludwig commented Dec 4, 2024

Validated the new ClipboardItem component and associated Button props are working in an extension via the the snapshot packages in Safari + local dev
image

@ryan-ludwig ryan-ludwig force-pushed the checkout-unstable-release branch from e446078 to 76f0c1c Compare December 4, 2024 21:34
@ryan-ludwig ryan-ludwig self-requested a review December 4, 2024 21:39
Copy link
Contributor

@jamesvidler jamesvidler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not tophat, but the changes in this PR look correct. Thank you for excluding other changes that may not have been ready.

Copy link
Contributor

@LucasLacerdaUX LucasLacerdaUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophatted used production store & spin + local-dev, on both Chrome and Safari.

image

@ryan-ludwig ryan-ludwig merged commit c95ad0c into unstable Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated Tag used by some bots that open PRs release Team - Checkout Extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants