Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting to string type for enabled features passed to the templates #2487

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

aeperea
Copy link
Contributor

@aeperea aeperea commented Nov 21, 2024

Background

We are now passing obfuscated flags as part of the __enabledFeatures property in the CustomerSegmentTemplateApi interface. Having hardcoded types defeat the purpose of obfuscation, so we are defaulting to a string type for these flags.

Solution

Switching types to string[]

🎩

  • ...

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Copy link
Contributor

@LTiger14 LTiger14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine given it's internal and backwards compatible anyway Also, that way we can pass unreleased features to our internal app.

@aeperea
Copy link
Contributor Author

aeperea commented Dec 2, 2024

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @aeperea! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/data-extensions": "0.0.0-snapshot-20241202151809",
"@shopify/ui-extensions": "0.0.0-snapshot-20241202151809",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241202151809"

@PrescilliaA
Copy link
Contributor

given it's internal

@LTiger14 I am trying to remember but I think we might be using the same API for 3P extensions? 🤔

@aeperea aeperea merged commit d0d667f into unstable Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants