Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare customer-account surface for 2024-04 #1857

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

robin-drexler
Copy link
Member

@robin-drexler robin-drexler commented Mar 26, 2024

Background

Same procedure as last time. Please read #1586 for more context and to see that the changes are very similar.

Note this PR will be merged into the 2024-04 branch, not into unstable

Solution

Sets customer account stable back to the 2024-01 version with a few additions.

🎩

I have an instance that uses this version of our npm packages and the types check out:

Only the order status extension points are available
image

Block and sheet are available
image

Extension still renders too:

image

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@robin-drexler robin-drexler force-pushed the rd/2024-04-customer-accounts branch from b919a74 to b42f85f Compare March 26, 2024 20:53
@robin-drexler
Copy link
Member Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @robin-drexler! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@robin-drexler robin-drexler marked this pull request as ready for review March 27, 2024 18:37
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@robin-drexler robin-drexler changed the title prepare customer-account surface prepare customer-account surface for 2024-04 Mar 27, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, interesting. it seems like this was missed in checkout and customer accounts. I'll ask around. we can create a new PR to adjust these to include the 2024 versions!

Copy link
Contributor

@oluwatimio oluwatimio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Robin!

Screenshot 2024-03-27 at 3 09 35 PM

@brianshen1990 brianshen1990 self-requested a review March 27, 2024 19:14
@robin-drexler robin-drexler force-pushed the rd/2024-04-customer-accounts branch from b42f85f to 58ad85b Compare March 27, 2024 19:19
Copy link
Contributor

@renerbaffa renerbaffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 ✅

@robin-drexler robin-drexler force-pushed the rd/2024-04-customer-accounts branch from 58ad85b to c4bc17b Compare March 27, 2024 19:34
@robin-drexler robin-drexler merged commit d5227a4 into 2024-04 Mar 27, 2024
5 checks passed
jamesvidler added a commit that referenced this pull request Apr 2, 2024
…ounts"

This reverts commit d5227a4, reversing
changes made to 4b7f832.
jamesvidler added a commit that referenced this pull request Apr 2, 2024
Revert "Merge pull request #1857 from Shopify/rd/2024-04-customer-accounts"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants