-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare customer-account surface for 2024-04 #1857
Conversation
b919a74
to
b42f85f
Compare
/snapit |
🫰✨ Thanks @robin-drexler! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
We detected some changes in |
packages/ui-extensions/src/surfaces/customer-account/api/order-status/order-status.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/customer-account/api/order-status/order-status.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for StorefrontApiVersion, will checkout support more? seems the stable version https://shopify.dev/docs/api/storefront is 2024-01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, interesting. it seems like this was missed in checkout and customer accounts. I'll ask around. we can create a new PR to adjust these to include the 2024 versions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/ui-extensions/src/surfaces/customer-account/components/shared-checkout-components.ts
Outdated
Show resolved
Hide resolved
b42f85f
to
58ad85b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 ✅
58ad85b
to
c4bc17b
Compare
Revert "Merge pull request #1857 from Shopify/rd/2024-04-customer-accounts"
Background
Same procedure as last time. Please read #1586 for more context and to see that the changes are very similar.
Note this PR will be merged into the 2024-04 branch, not into unstable
Solution
Sets customer account stable back to the 2024-01 version with a few additions.
confirmationNumber
is available on order status🎩
I have an instance that uses this version of our npm packages and the types check out:
Only the order status extension points are available
Block and sheet are available
Extension still renders too:
Checklist