Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support default.setting completion + hover #717

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Support default.setting completion + hover #717

merged 5 commits into from
Jan 23, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Jan 16, 2025 •
edited
Loading

What are you adding in this PR?

Fixes #625

  • Renamed PresetsSettingsPropertyCompletionProvider -> SettingsPropertyCompletionProvider
  • Renamed PresetsSettingsHoverProvider -> SettingsHoverProvider
  • Updated tests to ensure we can complete presets.settings and default.settings
    • fixed two bugs mentioned in changeset

Before you deploy

  • I included a minor bump changeset
  • My feature is backward compatible

@aswamy aswamy requested a review from charlespwd January 16, 2025 22:55
@aswamy aswamy requested a review from a team as a code owner January 16, 2025 22:55
graygilmore
graygilmore reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@graygilmore graygilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the renames happen in a single commit before any of the functional changes? I'm having a bit of a hard time deciphering what we want reviewed or not.

...ages/theme-language-server-common/src/json/hover/providers/ReferencedSettingHoverProvider.ts Outdated Show resolved Hide resolved
@aswamy aswamy force-pushed the feature/default-setting-completion branch from 1499af3 to e969f23 Compare January 17, 2025 16:32
@aswamy
Copy link
Contributor Author

aswamy commented Jan 17, 2025

@graygilmore I've broken it up into separate commits. Commit 3 is the bulk of the work - i would hide whitespaces since i've nested tests inside loops or describe blocks.

@aswamy aswamy force-pushed the feature/default-setting-completion branch from fe48498 to 2c87810 Compare January 17, 2025 17:21
graygilmore
graygilmore approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@graygilmore graygilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 🎩

packages/theme-language-server-node/src/metafieldDefinitions.ts
const { stdout } = await exec(`which shopify`);
return stdout.split('\n')[0].replace('\r', '');
if (process.env.NODE_ENV === 'test') {
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooo nice catch

@aswamy aswamy force-pushed the feature/default-setting-completion branch from 2c87810 to d5c123a Compare January 22, 2025 22:09
@aswamy aswamy merged commit 9765bec into main Jan 23, 2025
6 checks passed
@aswamy aswamy deleted the feature/default-setting-completion branch January 23, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graygilmore graygilmore graygilmore approved these changes

@charlespwd charlespwd Awaiting requested review from charlespwd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme block JSON preset setting + default setting completion/hover
2 participants
@aswamy @graygilmore