Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.4 #1153

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Ruby 3.4 #1153

merged 4 commits into from
Jan 22, 2025

Conversation

etiennebarrie
Copy link
Member

Update CI and development to Ruby 3.4.

Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the CI issue with BigDecimal -- I guess our options are to add bigdecimal to the 7.0 gemfile, or to drop Rails 7 x Ruby 3.4 support from the matrix?

Add the necessary gems which have been removed from 3.4. Ignore warnings
about blocks in Action View.
@etiennebarrie
Copy link
Member Author

I guess our options are to add bigdecimal to the 7.0 gemfile

Yeah, there was a bit more that was needed but not so bad IMO: 9ee7690

@etiennebarrie etiennebarrie merged commit 821115f into main Jan 22, 2025
39 checks passed
@etiennebarrie etiennebarrie deleted the update-ruby branch January 22, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants