Remove support for Rails 6.1 #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebarrie
approved these changes
Jan 22, 2025
| @@ -10,7 +10,7 @@ gem "debug" | |||
| gem "mocha" | |||
| gem "puma" | |||
| if !@rails_gem_requirement | |||
| gem "rails", ">= 6.1" | |||
| gem "rails", ">= 7.0" | |||
There was a problem hiding this comment.
We might not need that version requirement since have a requirement for the Rails frameworks we use in the gemspec. To be checked, but no big deal.
adrianna-chang-shopify
approved these changes
Jan 22, 2025
|
I'll remove the unnecessary required statuses. |
etiennebarrie
force-pushed
the
remove-support-for-rails-6-1
branch
from
9e56be2 to
81cf45a
Compare
|
Rebased on top of main for the Logger issue, see #1149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for Rails 6.1, it's EOL now.