New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include stacktrace in record behavior #68

Open

harirajv opened this issue May 13, 2022 · 1 comment

harirajv commented May 13, 2022

Currently, the record DeprecationBehavior removes the stacktrace from the deprecation message before writing to YAML- https://github.com/Shopify/deprecation_toolkit/blob/main/lib/deprecation_toolkit/behaviors/record.rb#L11

This stacktrace is pretty useful info but it is removed from the YAML content - https://github.com/Shopify/deprecation_toolkit/blob/main/lib/deprecation_toolkit/collector.rb#L36

I am willing to submit a pull request that can change the behaviour, but would like to confirm why this done.

@Edouard-chin @rafaelfranca

boardfish commented Sep 6, 2022

I'd also like to see this in CIRecordHelper. It might be good to default to just one line, but allow this to be controlled via config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment