Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug (parser function): TypeError: Cannot read properties of undefined (reading 'indexOf') #2

Open
gesinn-it-gea opened this issue Jul 12, 2024 · 1 comment
Open

bug (parser function): TypeError: Cannot read properties of undefined (reading 'indexOf') #2

gesinn-it-gea opened this issue Jul 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@gesinn-it-gea
Copy link
Member

A page with a simple graph:
image

Content:

{{#knowledgegraph:
 |nodes=PA1DCF0001
 |properties=Applied by Subproject
 |depth=0
 |show-property-type=false
 |graph-options=MediaWiki:KnowledgeGraphOptions
 |property-options?Organization logo=KnowledgeGraphOptionsImage
 |width=100%
 |height=400px 
 |properties-panel=true
}}

MediaWiki:KnowledgeGraphOptions does not exist. Having wrong graph-options should not lead to a JS error that could cause other JS crash on the same page.
@gesinn-it-gea gesinn-it-gea added the bug Something isn't working label Jul 12, 2024
@gesinn-it-gea
Copy link
Member Author

@thomas-topway-it can you have a look at this issue please?

paladox added a commit that referenced this issue Jan 16, 2025
@paladox
Fix for MW 1.43
3f66667 
>    │ TypeError: MediaWiki\Api\ApiBase::__construct(): Argument #2 ($moduleName) must be of type string, null given, called in /var/www/html/extensions/KnowledgeGraph/tests/phpunit/Unit/api/KnowledgeGraphApiLoadCategoriesTest.php on line 11


Changed in [0].

[0] wikimedia/mediawiki@1145328#diff-dfdd0dae9f9ed19e37ff6da63da042be73458adf8bda6151258aca1cd9a5ac86
@paladox paladox mentioned this issue Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gesinn-it-gea