You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout field is not marked as volatile or synchronized, which could cause visibility issues in multi-threaded scenarios when timeout is updated via setTimeout
Add an upper bound validation to prevent excessive timeout values that could lead to resource issues
Add an upper bound validation for the timeout value to prevent potential resource exhaustion or performance issues. A reasonable maximum timeout (e.g., 5 minutes) should be enforced.
public void setTimeout(Duration timeout) {
Require.nonNull("Timeout duration", timeout);
if (timeout.isNegative() || timeout.isZero()) {
throw new IllegalArgumentException("Timeout must be positive");
}
+ if (timeout.toMinutes() > 5) {+ throw new IllegalArgumentException("Timeout cannot exceed 5 minutes");+ }
this.timeout = timeout;
}
Apply this suggestion
Suggestion importance[1-10]: 7
Why: Adding an upper bound for timeout values is a good practice to prevent resource exhaustion and system hangs. The suggestion provides a reasonable limit of 5 minutes and includes proper validation logic.
@diemol I am not much clear about it. Initially, I thought the user can create a DevTools object with custom timeout, but I think that is not convenient.
Any suggestions/feedback are appreciated.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #14912
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Added an overloaded constructor to set custom timeouts in
DevTools.Introduced a
setTimeoutmethod to validate and update timeout duration.Ensured default timeout remains at 10 seconds for backward compatibility.
Improved error handling for invalid timeout values.
Changes walkthrough 📝
DevTools.java
Support custom timeout and validation in `DevTools`java/src/org/openqa/selenium/devtools/DevTools.java
setTimeoutmethod for timeout validation and assignment.