Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neohtop: Add version 1.1.2 #14478

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Nov 29, 2024

NeoHTOP - cross platform htop on steroids

package request fix #14812

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

neohtop

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik added the package-request-needed Need package-request issue label Nov 30, 2024
@aliesbelik
Copy link
Collaborator

Relates to Abdenasser/neohtop#71.

@rasa rasa changed the title Add neohtop neohtop: Add version 1.1.1 Dec 29, 2024
]
],
"checkver": {
"github": "https://github.com/Abdenasser/neohtop",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, it lookslike the checkver can be simplified to

    "checkver": "github",

This is because:-

  1. Regex is not needed as it matches the default regex
  2. The URL provided to the GitHub parameter matches the project's url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in a1d2609

@Slach
Copy link
Contributor Author

Slach commented Jan 27, 2025

/verify

Copy link
Contributor

Your changes do not pass checks.

neohtop

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@pratikpc
Copy link
Contributor

pratikpc commented Jan 27, 2025

Verify would fail as neohtop upstream is now on v1.1.2

You can take advantage of Scoop Check Version app to update the manifest.

https://github.com/ScoopInstaller/Scoop/wiki/App-Manifest-Autoupdate

Also remember to update the title.

I do not have merge access but other than that, LGTM

@Slach
Copy link
Contributor Author

Slach commented Jan 28, 2025

/verify

@Slach Slach changed the title neohtop: Add version 1.1.1 neohtop: Add version 1.1.2 Jan 28, 2025
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

neohtop

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Slach Slach requested a review from pratikpc January 30, 2025 11:00
@aliesbelik aliesbelik removed the package-request-needed Need package-request issue label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: neohtop
3 participants