-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neohtop: Add version 1.1.2 #14478
base: master
Are you sure you want to change the base?
neohtop: Add version 1.1.2 #14478
Conversation
All changes look good. Wait for review from human collaborators. neohtop
|
Relates to Abdenasser/neohtop#71. |
bucket/neohtop.json
Outdated
] | ||
], | ||
"checkver": { | ||
"github": "https://github.com/Abdenasser/neohtop", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it lookslike the checkver can be simplified to
"checkver": "github",
This is because:-
- Regex is not needed as it matches the default regex
- The URL provided to the GitHub parameter matches the project's url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in a1d2609
/verify |
Your changes do not pass checks. neohtop
|
Verify would fail as neohtop upstream is now on v1.1.2 You can take advantage of Scoop Check Version app to update the manifest. https://github.com/ScoopInstaller/Scoop/wiki/App-Manifest-Autoupdate Also remember to update the title. I do not have merge access but other than that, LGTM |
/verify |
All changes look good. Wait for review from human collaborators. neohtop
|
NeoHTOP - cross platform htop on steroids
package request fix #14812