-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update centralmoment() to support MonteCarlo() #29
Conversation
@ChrisRackauckas I have no idea why this test is failing. DiffEqSensitivity is in the TOML Extras and No issues locally when doing |
https://travis-ci.org/github/SciML/DiffEqUncertainty.jl/jobs/721741699#L380 It's a versioning issue. Something is keeping it back in the stone age. |
Why would it work locally though? I thought running |
hmmm... doing |
@ChrisRackauckas Can you rerun this test? This PR was held up by the [email protected] debacle. |
I bumped the tolerances a bit to make the new AD tests pass but I think there's a real failure somewhere. |
What's the blocker on this? My toy example fails (although it fails on both MonteCarlo and Koopman https://gist.github.com/sdwfrost/2c14346ced4d8279ef1769d1ef81d78d |
I think the main blocker is that we will need to change the repo substantially in order to really get the performance in check. It needs a DSL. Without it, it cannot do codegen in a way that's type stable. So that's a pretty big project that will startup in a bit here. |
Closes #28
Also added relevant tests.