Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov action #41

Closed
gdalle opened this issue Apr 12, 2024 · 6 comments · Fixed by #40
Closed

Add Codecov action #41

gdalle opened this issue Apr 12, 2024 · 6 comments · Fixed by #40

Comments

@gdalle
Copy link
Collaborator

gdalle commented Apr 12, 2024

I discovered in #40 that some lines were never tested, it would be good to have a Codecov workflow to spot that. With such a small package we should always be at 100% coverage

@ChrisRackauckas
Copy link
Member

@thazhemadam is going to do an overhaul centralization of our CI scripts soon, so this will get handled at that time.

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 13, 2024

Still it wouldn't cost much to activate it here, since I spotted uncovered lines and am currently doing a rather big overhaul in #40

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 13, 2024

I can do the yml part myself but I cannot add codecov as a GitHub app to the repo cause I'm not part of SciML

@ChrisRackauckas
Copy link
Member

All repos already have codecov.

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 13, 2024

Cool, I'll add the line to the workflow

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 13, 2024

Can I ask you for a look at #40 if you have some time? It's very minorly breaking but it will be a huge help for getting sparsity to work across backends

@gdalle gdalle linked a pull request Apr 15, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants