-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make permutation importance test optional, functionality to use any outcome variables, optional hyperparameter input #11
base: master
Are you sure you want to change the base?
Conversation
|
Define outcome variable and permutation logical as arguments that can be passed in the command line. We can now run from command line with:
|
address the last comment in SchlossLab#11
Previous changes regarding setting outcome and perm on the command line work when the user defines the outcome (e.g. "dx") as an argument. However, if they leave that argument empty (passed as NA e.g.
|
Caught the bug in line 87 and changed from
|
Nooo I was worried this wouldn't work but I wasn't doing permutation importance so I didn't catch it. I can look into another option if you don't know of one |
I'm running it now with the change I've made (it was passing first_outcome which is not a column that can be selected but now uses |
But don't we want to have dx not hard-coded? |
No I know, I have it as:
Instead of what it was before:
|
Our previous attempt was unsuccessful - must be a bug with tidyverse. I made a new change:
Not the most beautiful code snippet I've written but it'll do:) |
The NULL options for hyperparameters are currently specific to my CRC classification problem (except random forest, where we implement Pat's code: |
Fixes #6
Fixes #7
Fixes #8
Fixes #10