-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema for bun.lock
#4368
Add schema for bun.lock
#4368
Conversation
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
This comment was marked as resolved.
This comment was marked as resolved.
Thanks!
That's a good point, we don't currently have the testing setup to test that
Like you mention
If you'd like you can update the Prettier config ( Should I merge this or would you like to undo the formatting changes? :) |
yeah i ill try to fix formatting changes (still trailing comma difference, but thats minor just like this tbh) |
i dont know if i disabled prettier right, but it appears to work now! |
Great, thanks! |
@hyperupcall thanks for merging this :) btw i think I mixed up something as https://json.schemastore.org/bun.lock.json doesn't work (i think somewhere i assumed i had to sorry about that |
You're good! CI is supposed to catch that type of error (I'll have to look into it later) Feel free to make another PR fixing any mistakes - I kind of prefer the |
Yeah I think its better as too many |
Based on the TypeScript types I wrote, I have tried to make this into a json schema file. I haven't done this before so please tell me if I did something wrong.
Some things to note:
bun.lock
always has trailing comma's which I wanted to respect in the tests, however there didn't appear to be any way, so I had to remove them.bun.lock
file even though its meant to have each dep as one linejsonc
)"allowTrailingCommas": true,
to be boringbunfig.toml
here it also makes sense to have the other filesrelated to #4292