Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logout functionality #349

Closed
mirekdlugosz opened this issue Jun 28, 2019 · 1 comment
Closed

Implement logout functionality #349

mirekdlugosz opened this issue Jun 28, 2019 · 1 comment
Labels
enhancement New feature or request entity Related to entity coverage good first issue Good for newcomers low

Comments

@mirekdlugosz
Copy link
Contributor

LoginEntity().logout() does nothing:

airgun/airgun/entities/login.py

Lines 13 to 15 in 7b37535

def logout(self):
# fixme: not implemented
pass

See also #20
@mirekdlugosz mirekdlugosz added enhancement New feature or request good first issue Good for newcomers low entity Related to entity coverage labels Jun 28, 2019
@mirekdlugosz mirekdlugosz mentioned this issue Jun 28, 2019
Merged
@omkarkhatavkar omkarkhatavkar mentioned this issue Sep 17, 2019
Closed
@mirekdlugosz
Copy link
Contributor Author

Added in #474 , but see #475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request entity Related to entity coverage good first issue Good for newcomers low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #349 added logout method omkarkhatavkar/airgun
1 participant
@mirekdlugosz