Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delete entity mixin #19

Open
abalakh opened this issue Feb 22, 2018 · 1 comment
Open

Implement delete entity mixin #19

abalakh opened this issue Feb 22, 2018 · 1 comment
Labels

Comments

@abalakh
Copy link
Contributor

abalakh commented Feb 22, 2018

Similar to robottelo.ui.Base.delete we should create a helper method which will handle entity deletion and ensure deleted entity can't be found using search.
Couple of improvements which would be nice to have (thanks @oshtaier for pointing them):

  • cover the case when deleted entity was the last one available, so searchbar is not present anymore on entity list page
  • delete should return True/False whether deletion succeeded so we can easily assert deletion in tests like:
assert session.architecture.delete('foo')

so we could mark the test as failed (not errored) in case element was found.

@oshtaier oshtaier added the critical Critical issue. Requires resolving ASAP label Feb 22, 2018
@mfalesni
Copy link
Contributor

I think using exceptions may be more beneficial, you just do:

with some_expected_error_thing(FlashMessageException):
    create_bad_entity()

If a different error happens, it throws a different exception and that can be categorized.

@mirekdlugosz mirekdlugosz added low and removed critical Critical issue. Requires resolving ASAP labels Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants