New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntityExplodeEvent#blockList modifications are ignored? #28

Open

IAISI opened this issue Mar 2, 2025 · 0 comments

IAISI commented Mar 2, 2025

https://jd.papermc.io/paper/1.21.4/org/bukkit/event/entity/EntityExplodeEvent.html#blockList()

not sure how big of an issue this is but EntityExplodeEvent#blockList modifications are ignored which is inconsistent with paper where plugins could even clear List and readd blocks and those would still get exploded, case in point would be: https://github.com/GriefPrevention/GriefPrevention/blob/885c0eeb1f4cfed941383402c9be09964f430f41/src/main/java/me/ryanhamshire/GriefPrevention/EntityEventHandler.java#L525

I'm sure we can all agree GP code could be improved, but I suspect there might be other plugins that relay on this and could break.

Tested on latest Sakura 1.21.4 (dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment