Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Ask if you want to play the latest used torrent #95

Open
daviddia5 opened this issue Jan 28, 2025 · 5 comments
Open

[Enhancement] Ask if you want to play the latest used torrent #95

daviddia5 opened this issue Jan 28, 2025 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@daviddia5
Copy link

This was a very useful feature of Elementum.
Before accessing the indexers, it asks you if you want to use the last selected torrent for that movie or episode.
I leave it as a possible improvement :)

@Coffelius
Copy link
Collaborator

This sounds like a great feature—both useful and easy to implement.

If I understand correctly, you’re suggesting a playback setting to enable or disable remembering the last selected source for a video, making it easier to access next time.

I can think of two ways to do it. If you have another idea, feel free to share!

  1. A dialog before the source selection appears, allowing users to either bypass the selection list (OK) or proceed to it (Cancel).
  2. Always showing the source selection list but placing the last played source at the top with visual indicators.

The first approach avoids an extra search, while the second eliminates an additional dialog and reduces the number of required actions.

Which approach do you think works best?

@Coffelius Coffelius added the enhancement New feature or request label Jan 29, 2025
@daviddia5
Copy link
Author

daviddia5 commented Jan 29, 2025

Option 1. Something like this:
You previously selected the torrent (Name of the torrent). Do you want to use it again?
Yes (Play that torrent without making a new source search)
No (Appears source selection as before)

@Coffelius
Copy link
Collaborator

Okay, there is another feature that could be related to this one because it also involves a decision point before playback starts: ‘Resume the movie at minute xxx.’ Implementing this feature alongside the one you suggested would result in two consecutive dialogs. Alternatively, we could combine them into a single dialog with options to: play the previous source from the beginning, resume the previous source from where it left off, select a new source from the beginning, or select a new source from the point it was last played. This would require either two dialogs with two options each, or one dialog with four options.

If we display the list with the previous selection already at the top and focused, we can reduce the number of dialogs to just one, asking whether to continue the playback or start from the beginning. I think this latter option might offer a more pleasant flow.

I would implement the features with an option to toggle between these behaviors, then we can test them out.

Sounds good, right?

@daviddia5
Copy link
Author

I understand and it seems perfect to me :)
I have another question. Is it true that it asks you if you want to continue from minute x, shouldn't Kodi handle this?
In my Kodi options I have "Continue" set by default, and with other players it doesn't ask me anything, it just continues.

@daviddia5 daviddia5 changed the title [Enhancement] Ask if you want to use the latest torrent [Enhancement] Ask if you want to play the latest used torrent Jan 29, 2025
@Coffelius Coffelius self-assigned this Feb 1, 2025
@Coffelius
Copy link
Collaborator

Yes, Kodi automatically resumes playback when the video is part of your library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants