Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fmul in log10 intrinsic #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use fmul in log10 intrinsic #200

wants to merge 1 commit into from

Conversation

LegNeato
Copy link
Collaborator

@LegNeato LegNeato commented Jan 6, 2025

Fixes #199.

Firestar99
Firestar99 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Firestar99 Firestar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't know why there's two locations for the log10 intrinsic, but let's just get that fixed first.

@LegNeato
Copy link
Collaborator Author

LegNeato commented Jan 7, 2025

One is active when using libm, the other is when not using libm. Not sure if both are still needed or not, original was EmbarkStudios/rust-gpu#81. @eddyb care to enlighten us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firestar99 Firestar99 Firestar99 approved these changes

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@schell schell Awaiting requested review from schell schell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codegen error for log10
2 participants
@LegNeato @Firestar99