Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the inheritance example to something more meaningful (was remove TODO) #620

Closed
AlexDaniel opened this issue Jun 21, 2016 · 5 comments
Assignees
Labels
docs Documentation issue (primary issue type)

Comments

@AlexDaniel
Copy link
Member

The docs have a TODO notice written right in the text: http://doc.perl6.org/language/classtut#Inheritance

See also: Raku/book#58

@jonathanstowe
Copy link
Contributor

Frankly I would just take the redundant TODO out and change the title of this issue

@AlexDaniel
Copy link
Member Author

@jonathanstowe go for it.

jonathanstowe added a commit that referenced this issue Jun 21, 2016
@jonathanstowe jonathanstowe changed the title Remove TODO from text (or rewrite the example as it says) Improve the inheritance example to something more meaningful (was remove TODO) Jun 21, 2016
@jonathanstowe
Copy link
Contributor

In summary the discussion that gave rise to the original issue was that the example provided was a little contrived and lacked a clear rationale.

A good example should define a problem and show how it can be dealt with using inheritance.

@AlexDaniel AlexDaniel added the docs Documentation issue (primary issue type) label Jun 21, 2016
@JJ
Copy link
Contributor

JJ commented May 2, 2018

I would say this is no longer relevant. Maybe old issues should provide a link to particular commits in the repo.
In this case, TODO has been removed. Close?

@JJ JJ added the JJ TPF Grant label May 2, 2018
@JJ
Copy link
Contributor

JJ commented May 2, 2018

I see a couple of not very good practices (using say in methods) here and also a way to include in the example the fact that attributes are always private. I can change that if needed...

@JJ JJ self-assigned this May 4, 2018
@JJ JJ added this to the May SQUASHathon milestone May 4, 2018
JJ added a commit to JJ/my-raku-examples that referenced this issue May 4, 2018
@JJ JJ closed this as completed in bc6130b May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issue (primary issue type)
Projects
None yet
Development

No branches or pull requests

3 participants